Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow ptr to workgroup fn arguments #2507

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Disallow ptr to workgroup fn arguments #2507

merged 1 commit into from
Oct 17, 2023
+425 −450

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Sep 25, 2023

Resolves #2159.

@teoxoy teoxoy requested a review from jimblandy September 25, 2023 15:53
jimblandy
jimblandy requested changes Sep 25, 2023
View reviewed changes
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. We need a test in wgsl-errors.rs that these pointers are successfully forbidden.

I guess we don't document pointer argument address space restrictions anywhere right now. Oh well.

tests/in/access.wgsl Outdated Show resolved Hide resolved
@teoxoy teoxoy force-pushed the ptr-to-workgroup-fn branch from b3c3644 to 461988e Compare September 25, 2023 18:32
@teoxoy teoxoy requested a review from jimblandy September 25, 2023 18:33
@teoxoy teoxoy force-pushed the ptr-to-workgroup-fn branch from 461988e to bb19289 Compare October 13, 2023 16:24
@teoxoy teoxoy requested a review from a team as a code owner October 13, 2023 16:24
jimblandy
jimblandy approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jimblandy jimblandy merged commit 6854b0a into gfx-rs:master Oct 17, 2023
9 checks passed
@teoxoy teoxoy deleted the ptr-to-workgroup-fn branch October 17, 2023 08:07
@chenrui333 chenrui333 mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimblandy jimblandy jimblandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disallow ptr to workgroup fn arguments
2 participants
@teoxoy @jimblandy